Skip to content

validate region is a valid host label when used in endpoints#4383

Merged
aajtodd merged 2 commits intomainfrom
aajtodd/fix-region-validation
Nov 6, 2025
Merged

validate region is a valid host label when used in endpoints#4383
aajtodd merged 2 commits intomainfrom
aajtodd/fix-region-validation

Conversation

@aajtodd
Copy link
Contributor

@aajtodd aajtodd commented Nov 5, 2025

Motivation and Context

V1988105516

Description

  • Adds validation for edge case where region is not a valid host label.
  • Introduces new EndpointCustomization::endpointParamsBuilderValidator method that customizations can use to add further validation to crate::config::endpoint::ParamsBuilder::build(). We could have done this in a few different places but this seemed most appropriate.

Testing

New codegen integration test.

Checklist

  • For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "client," "server," or both in the applies_to key.
  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aajtodd aajtodd requested review from a team as code owners November 5, 2025 22:00
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

A new generated diff is ready to view.

A new doc preview is ready to view.

@aajtodd aajtodd force-pushed the aajtodd/fix-region-validation branch from 8d33f9d to 3af3cf1 Compare November 6, 2025 14:14
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

A new generated diff is ready to view.

A new doc preview is ready to view.

@aajtodd aajtodd merged commit 4533810 into main Nov 6, 2025
50 checks passed
@aajtodd aajtodd deleted the aajtodd/fix-region-validation branch November 6, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants